sky/engine/core/frame/FrameConsole.h - Issue 709203002: Remove more oilpan.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/frame/FrameConsole.h

Issue 709203002: Remove more oilpan. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/frame/FrameConsole.h

diff --git a/sky/engine/core/frame/FrameConsole.h b/sky/engine/core/frame/FrameConsole.h

index 3bb2a2be91750d05559b3d1976324eebd401f214..b2d9d4e2d46fbd9e828b576a5f0bba4546ba6cac 100644

--- a/sky/engine/core/frame/FrameConsole.h

+++ b/sky/engine/core/frame/FrameConsole.h

@@ -46,7 +46,7 @@ class ScriptCallStack;

// FrameConsole takes per-frame console messages and routes them up through the FrameHost to the ChromeClient and Inspector.

// It's meant as an abstraction around ChromeClient calls and the way that Blink core/ can add messages to the console.

-class FrameConsole final : public DummyBase<FrameConsole> {

+class FrameConsole final {

DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED(FrameConsole);

public:

static PassOwnPtr<FrameConsole> create(LocalFrame& frame)

« no previous file with comments | « sky/engine/core/frame/Frame.h ('k') | sky/engine/core/frame/FrameHost.h » ('j') | no next file with comments »