Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 709193002: [Smart Lock] Update a couple of UI strings. (Closed)

Created:
6 years, 1 month ago by Ilya Sherman
Modified:
6 years, 1 month ago
Reviewers:
Tim Song
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Smart Lock] Update a couple of UI strings. These match the latest UX team recommendations. BUG=431334 TEST=none R=tengs@chromium.org Committed: https://crrev.com/b2b83f6d478e75f556a7d1ad9108bf37fa2e2a44 Cr-Commit-Position: refs/heads/master@{#303357}

Patch Set 1 #

Patch Set 2 : Keep two separate strings, just in case we want them to diverge eventually. #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/signin/easy_unlock_screenlock_state_handler.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Ilya Sherman
6 years, 1 month ago (2014-11-08 00:08:25 UTC) #1
Tim Song
lgtm
6 years, 1 month ago (2014-11-08 00:13:34 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709193002/20001
6 years, 1 month ago (2014-11-08 00:23:05 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/89427) win_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/84059) android_aosp ...
6 years, 1 month ago (2014-11-08 00:28:26 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709193002/40001
6 years, 1 month ago (2014-11-08 01:15:03 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
6 years, 1 month ago (2014-11-08 02:27:19 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-08 02:28:48 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b2b83f6d478e75f556a7d1ad9108bf37fa2e2a44
Cr-Commit-Position: refs/heads/master@{#303357}

Powered by Google App Engine
This is Rietveld 408576698