Issue 709133004: Remove TimeRanges.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 709133004: Remove TimeRanges. (Closed)

Created:
6 years, 1 month ago by esprehn

Modified:
6 years, 1 month ago

Reviewers:
abarth-chromium, eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, ojan

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove TimeRanges. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/eb1df6c65f0ac512203829d592caa0082c14e343

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -725 lines)			Patch
M	sky/engine/core/core.gni	View	2 chunks	+0 lines, -3 lines	0 comments	Download
D	sky/engine/core/html/TimeRanges.h	View	1 chunk	+0 lines, -133 lines	0 comments	Download
D	sky/engine/core/html/TimeRanges.cpp	View	1 chunk	+0 lines, -206 lines	0 comments	Download
D	sky/engine/core/html/TimeRanges.idl	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	sky/engine/core/html/TimeRangesTest.cpp	View	1 chunk	+0 lines, -300 lines	0 comments	Download
D	sky/engine/public/platform/WebTimeRange.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

esprehn

On 2014/11/07 at 22:52:32, eseidel wrote: > Were these for media? Yeah https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit/Source/core/html/HTMLMediaElement.idl&q=TimeRanges%20file:idl&sq=package:chromium&type=cs&l=47

6 years, 1 month ago (2014-11-07 22:57:24 UTC) #4

esprehn

6 years, 1 month ago (2014-11-07 23:18:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
eb1df6c65f0ac512203829d592caa0082c14e343 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages