Teach TurboFan to call C functions with result_size > 1.

src/compiler/js-graph.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/code-stubs.h"
 #include "src/compiler/js-graph.h"
 #include "src/compiler/node-properties-inl.h"
 #include "src/compiler/typer.h"
 
 namespace v8 {
 namespace internal {
 namespace compiler {
 
 Node* JSGraph::ImmovableHeapConstant(Handle<HeapObject> object) {
   Unique<HeapObject> unique = Unique<HeapObject>::CreateImmovable(object);
   return graph()->NewNode(common()->HeapConstant(unique));
 }
 
 
-Node* JSGraph::CEntryStubConstant() {
-  if (!c_entry_stub_constant_.is_set()) {
-    c_entry_stub_constant_.set(
-        ImmovableHeapConstant(CEntryStub(isolate(), 1).GetCode()));
+Node* JSGraph::CEntryStubConstant(int result_size) {
+  if (result_size == 1) {
+    if (!c_entry_stub_constant_.is_set()) {
+      c_entry_stub_constant_.set(
+          ImmovableHeapConstant(CEntryStub(isolate(), 1).GetCode()));
+    }
+    return c_entry_stub_constant_.get();
   }
-  return c_entry_stub_constant_.get();
+
+  DCHECK(result_size == 2);

[titzer, 2014/11/07 14:53:06]

Any risk in just passing the result_size through to the CEntryStub (i.e. skip
the assert)?

[mvstanton, 2014/11/07 15:00:00]

Done.

+  return ImmovableHeapConstant(CEntryStub(isolate(), 2).GetCode());
 }
 
 
 Node* JSGraph::UndefinedConstant() {
   if (!undefined_constant_.is_set()) {
     undefined_constant_.set(
         ImmovableHeapConstant(factory()->undefined_value()));
   }
   return undefined_constant_.get();
 }
@@ skipping 164 matching lines @@
       &true_constant_,         &false_constant_,     &null_constant_,
       &zero_constant_,         &one_constant_,       &nan_constant_};
   for (size_t i = 0; i < arraysize(ptrs); i++) {
     if (ptrs[i]->is_set()) nodes->push_back(ptrs[i]->get());
   }
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8