Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: media/audio/mac/audio_auhal_mac.h

Issue 70903002: Dynamically FIFO when OSX requests unexpected frame counts. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add log. Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | media/audio/mac/audio_auhal_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/audio/mac/audio_auhal_mac.h
diff --git a/media/audio/mac/audio_auhal_mac.h b/media/audio/mac/audio_auhal_mac.h
index 66feb8d0d11f43358626b5d657e2a51b4edcd00f..b488b73c0d135e7047b882b76dc6aae3e8d3a633 100644
--- a/media/audio/mac/audio_auhal_mac.h
+++ b/media/audio/mac/audio_auhal_mac.h
@@ -28,6 +28,7 @@
namespace media {
class AudioManagerMac;
+class AudioPullFifo;
// Implementation of AudioOuputStream for Mac OS X using the
// AUHAL Audio Unit present in OS 10.4 and later.
@@ -83,6 +84,9 @@ class AUHALStream : public AudioOutputStream {
UInt32 number_of_frames,
AudioBufferList* io_data);
+ // Called by either |audio_fifo_| or Render() to provide audio data.
+ void ProvideInput(int frame_delay, AudioBus* dest);
+
// Helper method to enable input and output.
bool EnableIO(bool enable, UInt32 scope);
@@ -108,15 +112,15 @@ class AUHALStream : public AudioOutputStream {
double GetPlayoutLatency(const AudioTimeStamp* output_time_stamp);
// Our creator, the audio manager needs to be notified when we close.
- AudioManagerMac* manager_;
+ AudioManagerMac* const manager_;
- AudioParameters params_;
+ const AudioParameters params_;
// For convenience - same as in params_.
- int input_channels_;
- int output_channels_;
+ const int input_channels_;
+ const int output_channels_;
// Buffer-size.
- size_t number_of_frames_;
+ const size_t number_of_frames_;
// Pointer to the object that will provide the audio samples.
AudioSourceCallback* source_;
@@ -131,7 +135,7 @@ class AUHALStream : public AudioOutputStream {
// The audio device to use with the AUHAL.
// We can potentially handle both input and output with this device.
- AudioDeviceID device_;
+ const AudioDeviceID device_;
// The AUHAL Audio Unit which talks to |device_|.
AudioUnit audio_unit_;
@@ -145,10 +149,6 @@ class AUHALStream : public AudioOutputStream {
// The flag used to stop the streaming.
bool stopped_;
- // The flag used to indicate if the AudioManager has been notified of a
- // potential device change. Reset to false during Start().
- bool notified_for_possible_device_change_;
-
// The input AudioUnit renders its data here.
scoped_ptr<uint8[]> input_buffer_list_storage_;
AudioBufferList* input_buffer_list_;
@@ -159,6 +159,13 @@ class AUHALStream : public AudioOutputStream {
// Container for retrieving data from AudioSourceCallback::OnMoreIOData().
scoped_ptr<AudioBus> output_bus_;
+ // Dynamically allocated FIFO used when CoreAudio asks for unexpected frame
+ // sizes.
+ scoped_ptr<AudioPullFifo> audio_fifo_;
+
+ // Current buffer delay. Set by Render().
+ uint32 current_hardware_pending_bytes_;
+
DISALLOW_COPY_AND_ASSIGN(AUHALStream);
};
« no previous file with comments | « no previous file | media/audio/mac/audio_auhal_mac.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698