Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Side by Side Diff: Source/bindings/templates/interface.cpp

Issue 709023003: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% extends 'interface_base.cpp' %} 1 {% extends 'interface_base.cpp' %}
2 2
3 3
4 {##############################################################################} 4 {##############################################################################}
5 {% block indexed_property_getter %} 5 {% block indexed_property_getter %}
6 {% if indexed_property_getter and not indexed_property_getter.is_custom %} 6 {% if indexed_property_getter and not indexed_property_getter.is_custom %}
7 {% set getter = indexed_property_getter %} 7 {% set getter = indexed_property_getter %}
8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info) 8 static void indexedPropertyGetter(uint32_t index, const v8::PropertyCallbackInfo <v8::Value>& info)
9 { 9 {
10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder()); 10 {{cpp_class}}* impl = {{v8_class}}::toImpl(info.Holder());
(...skipping 665 matching lines...) Expand 10 before | Expand all | Expand 10 after
676 676
677 {% endif %} 677 {% endif %}
678 {% endblock %} 678 {% endblock %}
679 679
680 680
681 {##############################################################################} 681 {##############################################################################}
682 {% block configure_shadow_object_template %} 682 {% block configure_shadow_object_template %}
683 {% if interface_name == 'Window' %} 683 {% if interface_name == 'Window' %}
684 static void configureShadowObjectTemplate(v8::Handle<v8::ObjectTemplate> templ, v8::Isolate* isolate) 684 static void configureShadowObjectTemplate(v8::Handle<v8::ObjectTemplate> templ, v8::Isolate* isolate)
685 { 685 {
686 V8DOMConfiguration::installAttributes(templ, v8::Handle<v8::ObjectTemplate>( ), shadowAttributes, WTF_ARRAY_LENGTH(shadowAttributes), isolate); 686 V8DOMConfiguration::installAttributes(isolate, templ, v8::Handle<v8::ObjectT emplate>(), shadowAttributes, WTF_ARRAY_LENGTH(shadowAttributes));
687 687
688 // Install a security handler with V8. 688 // Install a security handler with V8.
689 templ->SetAccessCheckCallbacks(V8Window::namedSecurityCheckCustom, V8Window: :indexedSecurityCheckCustom, v8::External::New(isolate, const_cast<WrapperTypeIn fo*>(&V8Window::wrapperTypeInfo))); 689 templ->SetAccessCheckCallbacks(V8Window::namedSecurityCheckCustom, V8Window: :indexedSecurityCheckCustom, v8::External::New(isolate, const_cast<WrapperTypeIn fo*>(&V8Window::wrapperTypeInfo)));
690 templ->SetInternalFieldCount(V8Window::internalFieldCount); 690 templ->SetInternalFieldCount(V8Window::internalFieldCount);
691 } 691 }
692 692
693 {% endif %} 693 {% endif %}
694 {% endblock %} 694 {% endblock %}
695 695
696 696
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
984 } 984 }
985 985
986 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %} 986 {% for method in methods if method.overloads and method.overloads.has_partial_ov erloads %}
987 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&)) 987 void {{v8_class}}::register{{method.name | blink_capitalize}}MethodForPartialInt erface(void (*method)(const v8::FunctionCallbackInfo<v8::Value>&))
988 { 988 {
989 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method; 989 {{cpp_class}}V8Internal::{{method.name}}MethodForPartialInterface = method;
990 } 990 }
991 {% endfor %} 991 {% endfor %}
992 {% endif %} 992 {% endif %}
993 {% endblock %} 993 {% endblock %}
OLDNEW
« no previous file with comments | « Source/bindings/templates/constants.cpp ('k') | Source/bindings/tests/results/core/V8TestException.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698