Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java

Issue 709003004: Fix leaked external surface when several EME videos coexist (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added AUTHORS Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java
diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java
index d7484028592f1aac1f8f428a057c3c980fac9512..2769be9f44019003aee374162b94b9c984b91cee 100644
--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java
+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/ExternalVideoSurfaceContainer.java
@@ -124,9 +124,7 @@ public class ExternalVideoSurfaceContainer implements SurfaceHolder.Callback {
protected void requestExternalVideoSurface(int playerId) {
if (mPlayerId == playerId) return;
- if (mPlayerId == INVALID_PLAYER_ID) {
- setActiveContainer(this);
- }
+ setActiveContainer(this);
mPlayerId = playerId;
initializeCurrentPositionOfSurfaceView();
@@ -175,6 +173,7 @@ public class ExternalVideoSurfaceContainer implements SurfaceHolder.Callback {
}
private void createSurfaceView() {
+ assert mSurfaceView == null;
mSurfaceView = new NoPunchingSurfaceView(mContentViewCore.getContext());
mSurfaceView.getHolder().addCallback(this);
// SurfaceHoder.surfaceCreated() will be called after the SurfaceView is attached to
« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/ExternalVideoSurfaceContainer.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698