Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 709003003: Revert of [ServiceWorkerCache Cleanup] Make the state of the cache backend explicit (Closed)

Created:
6 years, 1 month ago by jkarlin
Modified:
6 years, 1 month ago
Reviewers:
michaeln, falken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@close_async
Project:
chromium
Visibility:
Public.

Description

Revert of [ServiceWorkerCache Cleanup] Make the state of the cache backend explicit (patchset #2 id:20001 of https://codereview.chromium.org/701403002/) Reason for revert: There is a bad DCHECK causing layout tests to fail. Reverting and fixing later so that I can turn the tests back on asap as this patch is non-essential and it's branch day. BUG=431163 Original issue's description: > [ServiceWorkerCache] Make the state of the cache backend explicit > > The ServiceWorkerCache's backend transitions from uninitialized, to > open, to closed. Make that explicit in code by adding a state > variable instead of checking the state of the initialized_ and > backend_ member variables. > > BUG=430884 > > Committed: https://crrev.com/7fbcce797ed32cf1d653ca5e4bf1dfad4cd7fc46 > Cr-Commit-Position: refs/heads/master@{#303115} TBR=michaeln@chromium.org,falken@chromium.org NOTREECHECKS=true NOTRY=true BUG=430884 Committed: https://crrev.com/0d9168154dea976f5f490666791d3c44e68c9ea6 Cr-Commit-Position: refs/heads/master@{#303226}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -65 lines) Patch
M content/browser/service_worker/service_worker_cache.h View 3 chunks +2 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_cache.cc View 11 chunks +38 lines, -54 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jkarlin
Created Revert of [ServiceWorkerCache Cleanup] Make the state of the cache backend explicit
6 years, 1 month ago (2014-11-07 12:46:45 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/709003003/1
6 years, 1 month ago (2014-11-07 12:47:06 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-07 12:47:26 UTC) #3
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 12:48:11 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0d9168154dea976f5f490666791d3c44e68c9ea6
Cr-Commit-Position: refs/heads/master@{#303226}

Powered by Google App Engine
This is Rietveld 408576698