Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart

Issue 708993003: Revert "Revert "dart2js: Add a type parameter to class Reference...."" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart
diff --git a/tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart b/tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart
index df563db2ed6c7ecbfde2b57f59117cf13c8cf621..1d84848c8bd4c4c64b6fe5965eed97142146a488 100644
--- a/tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart
+++ b/tests/compiler/dart2js/backend_dart/opt_redundant_phi_test.dart
@@ -192,7 +192,7 @@ String SCOPING_OUT = """
// Ensures that continuations which are never invoked are not optimized.
// IR written by hand.
-String NEVER_INVOKED1_IN = """
+String NEVER_INVOKED_IN = """
(FunctionDefinition main ( return)
(LetPrim v0 (Constant IntConstant(0)))
(LetCont (k0 v1)
@@ -200,31 +200,7 @@ String NEVER_INVOKED1_IN = """
(InvokeContinuation return v0))
""";
-String NEVER_INVOKED1_OUT = NEVER_INVOKED1_IN;
-
-// As in the previous test, except with the added wrinkle of higher order
-// continuations.
-
-String NEVER_INVOKED2_IN = """
-(FunctionDefinition main ( return)
- (LetCont (k0 v0)
- (InvokeStatic print v0 return))
- (InvokeContinuation return k0))
-""";
-
-String NEVER_INVOKED2_OUT = NEVER_INVOKED2_IN;
-
-// As in the previous test, but the continuation is invoked as well as passed
-// as an argument.
-
-String AS_ARG_IN = """
-(FunctionDefinition main ( return)
- (LetCont (k0 v0)
- (InvokeStatic print v0 return))
- (InvokeContinuation k0 k0))
-""";
-
-String AS_ARG_OUT = AS_ARG_IN;
+String NEVER_INVOKED_OUT = NEVER_INVOKED_IN;
/// Normalizes whitespace by replacing all whitespace sequences by a single
/// space and trimming leading and trailing whitespace.
@@ -253,7 +229,5 @@ void main() {
testRedundantPhi(INNER_LOOP_IN, INNER_LOOP_OUT);
testRedundantPhi(BASIC_LOOP_IN, BASIC_LOOP_OUT);
testRedundantPhi(SCOPING_IN, SCOPING_OUT);
- testRedundantPhi(NEVER_INVOKED1_IN, NEVER_INVOKED1_OUT);
- testRedundantPhi(NEVER_INVOKED2_IN, NEVER_INVOKED2_OUT);
- testRedundantPhi(AS_ARG_IN, AS_ARG_OUT);
+ testRedundantPhi(NEVER_INVOKED_IN, NEVER_INVOKED_OUT);
}

Powered by Google App Engine
This is Rietveld 408576698