Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1181)

Unified Diff: sky/engine/core/dom/RenderTreeBuilder.cpp

Issue 708913002: Remove rendererIsNeeded. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/dom/shadow/InsertionPoint.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/core/dom/RenderTreeBuilder.cpp
diff --git a/sky/engine/core/dom/RenderTreeBuilder.cpp b/sky/engine/core/dom/RenderTreeBuilder.cpp
index 23ef037d9040736a56605a827e4c41ffa85bbbbe..00cd97e72ead1e5826ab3e2750e3ea13fc727fa9 100644
--- a/sky/engine/core/dom/RenderTreeBuilder.cpp
+++ b/sky/engine/core/dom/RenderTreeBuilder.cpp
@@ -29,10 +29,10 @@
#include "core/css/resolver/StyleResolver.h"
#include "core/dom/Node.h"
#include "core/dom/Text.h"
+#include "core/dom/shadow/InsertionPoint.h"
#include "core/rendering/RenderObject.h"
#include "core/rendering/RenderText.h"
#include "core/rendering/RenderView.h"
-#include "platform/RuntimeEnabledFeatures.h"
namespace blink {
@@ -62,6 +62,8 @@ bool RenderTreeBuilder::shouldCreateRenderer() const
return false;
if (!parentRenderer->canHaveChildren())
return false;
+ if (isActiveInsertionPoint(*m_node))
+ return false;
return true;
}
@@ -82,7 +84,7 @@ void RenderTreeBuilder::createRendererForElementIfNeeded()
Element* element = toElement(m_node);
RenderStyle& style = this->style();
- if (!element->rendererIsNeeded(style))
+ if (style.display() == NONE)
return;
RenderObject* newRenderer = element->createRenderer(&style);
« no previous file with comments | « sky/engine/core/dom/Element.cpp ('k') | sky/engine/core/dom/shadow/InsertionPoint.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698