Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Side by Side Diff: sky/engine/core/dom/Element.cpp

Issue 708913002: Remove rendererIsNeeded. (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/RenderTreeBuilder.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Peter Kelly (pmk@post.com) 4 * (C) 2001 Peter Kelly (pmk@post.com)
5 * (C) 2001 Dirk Mueller (mueller@kde.org) 5 * (C) 2001 Dirk Mueller (mueller@kde.org)
6 * (C) 2007 David Smith (catfish.man@gmail.com) 6 * (C) 2007 David Smith (catfish.man@gmail.com)
7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved. 7 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
8 * (C) 2007 Eric Seidel (eric@webkit.org) 8 * (C) 2007 Eric Seidel (eric@webkit.org)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 771 matching lines...) Expand 10 before | Expand all | Expand 10 after
782 String Element::nodeName() const 782 String Element::nodeName() const
783 { 783 {
784 return m_tagName.localName(); 784 return m_tagName.localName();
785 } 785 }
786 786
787 const AtomicString Element::imageSourceURL() const 787 const AtomicString Element::imageSourceURL() const
788 { 788 {
789 return getAttribute(HTMLNames::srcAttr); 789 return getAttribute(HTMLNames::srcAttr);
790 } 790 }
791 791
792 bool Element::rendererIsNeeded(const RenderStyle& style)
793 {
794 return style.display() != NONE;
795 }
796
797 RenderObject* Element::createRenderer(RenderStyle* style) 792 RenderObject* Element::createRenderer(RenderStyle* style)
798 { 793 {
799 return RenderObject::createObject(this, style); 794 return RenderObject::createObject(this, style);
800 } 795 }
801 796
802 Node::InsertionNotificationRequest Element::insertedInto(ContainerNode* insertio nPoint) 797 Node::InsertionNotificationRequest Element::insertedInto(ContainerNode* insertio nPoint)
803 { 798 {
804 // need to do superclass processing first so inDocument() is true 799 // need to do superclass processing first so inDocument() is true
805 // by the time we reach updateId 800 // by the time we reach updateId
806 ContainerNode::insertedInto(insertionPoint); 801 ContainerNode::insertedInto(insertionPoint);
(...skipping 1057 matching lines...) Expand 10 before | Expand all | Expand 10 after
1864 return false; 1859 return false;
1865 // Turn off style sharing for elements that can gain layers for reasons outs ide of the style system. 1860 // Turn off style sharing for elements that can gain layers for reasons outs ide of the style system.
1866 // See comments in RenderObject::setStyle(). 1861 // See comments in RenderObject::setStyle().
1867 // FIXME: Why does gaining a layer from outside the style system require dis abling sharing? 1862 // FIXME: Why does gaining a layer from outside the style system require dis abling sharing?
1868 if (isHTMLCanvasElement(*this)) 1863 if (isHTMLCanvasElement(*this))
1869 return false; 1864 return false;
1870 return true; 1865 return true;
1871 } 1866 }
1872 1867
1873 } // namespace blink 1868 } // namespace blink
OLDNEW
« no previous file with comments | « sky/engine/core/dom/Element.h ('k') | sky/engine/core/dom/RenderTreeBuilder.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698