Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 708903005: DevTools: don't spam console with messages about unreachable objects in heap snapshot (Closed)

Created:
6 years, 1 month ago by yurys
Modified:
6 years, 1 month ago
Reviewers:
loislo
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

DevTools: don't spam console with messages about unreachable objects in heap snapshot Log this messages into the DevTools' front-end's console instead. BUG=430812, 426809 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184972

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M Source/devtools/front_end/heap_snapshot_worker/HeapSnapshot.js View 1 3 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
yurys
6 years, 1 month ago (2014-11-07 13:39:45 UTC) #2
loislo
lgtm
6 years, 1 month ago (2014-11-07 13:41:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708903005/1
6 years, 1 month ago (2014-11-07 13:41:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708903005/20001
6 years, 1 month ago (2014-11-07 13:43:16 UTC) #7
commit-bot: I haz the power
6 years, 1 month ago (2014-11-07 15:28:18 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 184972

Powered by Google App Engine
This is Rietveld 408576698