sky/viewer/document_view.h - Issue 708903002: Initial work on a new <view> element backed by a mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/viewer/document_view.h

Issue 708903002: Initial work on a new <view> element backed by a mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: more review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/viewer/document_view.h

diff --git a/sky/viewer/document_view.h b/sky/viewer/document_view.h

index aa36ebd2ba143c9498319c3f769763c42f1b0185..88abb6a92503fc1756d10354214791b2d9cd9071 100644

--- a/sky/viewer/document_view.h

+++ b/sky/viewer/document_view.h

@@ -69,6 +69,7 @@ class DocumentView : public mojo::InterfaceImpl<mojo::Application>,

virtual blink::WebLayerTreeView* initializeLayerTreeView();

// WebFrameClient methods:

+ void createChildView(const blink::WebURL&) override;

void frameDetached(blink::WebFrame*) override;

blink::WebNavigationPolicy decidePolicyForNavigation(

const blink::WebFrameClient::NavigationPolicyInfo& info) override;