sky/engine/web/FrameLoaderClientImpl.h - Issue 708903002: Initial work on a new <view> element backed by a mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/web/FrameLoaderClientImpl.h

Issue 708903002: Initial work on a new <view> element backed by a mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: more review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/web/FrameLoaderClientImpl.h

diff --git a/sky/engine/web/FrameLoaderClientImpl.h b/sky/engine/web/FrameLoaderClientImpl.h

index 4286c5db479c08db84f47f15de3a730b2ae948dc..54582f6b7cc6dcbc13403ee701ba08796004d77b 100644

--- a/sky/engine/web/FrameLoaderClientImpl.h

+++ b/sky/engine/web/FrameLoaderClientImpl.h

@@ -73,6 +73,7 @@ public:

virtual void didStopLoading() override;

virtual void progressEstimateChanged(double progressEstimate) override;

virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& suggestedName = String()) override;

+ virtual void createView(const KURL&) override;

virtual void selectorMatchChanged(const Vector<String>& addedSelectors, const Vector<String>& removedSelectors) override;

virtual void transitionToCommittedForNewPage() override;

virtual void didChangeScrollOffset() override;