sky/engine/core/loader/EmptyClients.h - Issue 708903002: Initial work on a new <view> element backed by a mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/loader/EmptyClients.h

Issue 708903002: Initial work on a new <view> element backed by a mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: more review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/loader/EmptyClients.h

diff --git a/sky/engine/core/loader/EmptyClients.h b/sky/engine/core/loader/EmptyClients.h

index 74309c96d9bfbd744e47f8f9547e05630ee12168..e29586b314fcf0d65896e665da38060b93b0f0bb 100644

--- a/sky/engine/core/loader/EmptyClients.h

+++ b/sky/engine/core/loader/EmptyClients.h

@@ -130,6 +130,7 @@ public:

virtual void didStopLoading() override { }

virtual void loadURLExternally(const ResourceRequest&, NavigationPolicy, const String& = String()) override { }

+ virtual void createView(const KURL&) override {}

virtual void transitionToCommittedForNewPage() override { }