sky/engine/core/core.gni - Issue 708903002: Initial work on a new <view> element backed by a mojo::View.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/core.gni

Issue 708903002: Initial work on a new <view> element backed by a mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master

Patch Set: more review comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/core/core.gni

diff --git a/sky/engine/core/core.gni b/sky/engine/core/core.gni

index 5c42160535913aa402cc08523533ce7ea3b5757e..05ba81df95dc5ecf89f05f623df03024f3f27bd1 100644

--- a/sky/engine/core/core.gni

+++ b/sky/engine/core/core.gni

@@ -770,6 +770,8 @@ sky_core_files = [

"html/HTMLTemplateElement.h",

"html/HTMLTitleElement.cpp",

"html/HTMLTitleElement.h",

+ "html/HTMLIFrameElement.cpp",

+ "html/HTMLIFrameElement.h",

"html/ImageData.cpp",

"html/ImageData.h",

"html/PublicURLManager.cpp",

@@ -1056,6 +1058,7 @@ sky_core_files = [

"rendering/RenderLineBoxList.cpp",

"rendering/RenderObject.cpp",

"rendering/RenderObjectChildList.cpp",

+ "rendering/RenderRemote.cpp",

"rendering/RenderReplaced.cpp",

"rendering/RenderSelectionInfo.h",

"rendering/RenderText.cpp",

@@ -1227,6 +1230,7 @@ core_idl_files = get_path_info([

"html/HTMLContentElement.idl",

"html/HTMLDocument.idl",

"html/HTMLElement.idl",

+ "html/HTMLIFrameElement.idl",

"html/HTMLImageElement.idl",

"html/HTMLImportElement.idl",

"html/HTMLPictureElement.idl",