Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Unified Diff: sky/engine/core/html/HTMLViewElement.h

Issue 708903002: Initial work on a new <view> element backed by a mojo::View. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/engine/core/html/HTMLViewElement.h
diff --git a/sky/engine/core/html/HTMLAnchorElement.h b/sky/engine/core/html/HTMLViewElement.h
similarity index 63%
copy from sky/engine/core/html/HTMLAnchorElement.h
copy to sky/engine/core/html/HTMLViewElement.h
index 508479594381d75822c040283a6c3acf54cdb047..073255abd155b31e15e5f7091b9cf7f15b221944 100644
--- a/sky/engine/core/html/HTMLAnchorElement.h
+++ b/sky/engine/core/html/HTMLViewElement.h
@@ -21,8 +21,8 @@
*
*/
esprehn 2014/11/06 22:40:28 Use the 3 line google copyright.
Matt Perry 2014/11/06 23:38:50 Done.
-#ifndef HTMLAnchorElement_h
-#define HTMLAnchorElement_h
+#ifndef HTMLViewElement_h
+#define HTMLViewElement_h
#include "core/HTMLNames.h"
#include "core/dom/DOMURLUtils.h"
@@ -31,30 +31,30 @@
namespace blink {
-class HTMLAnchorElement : public HTMLElement {
+class HTMLViewElement : public HTMLElement {
DEFINE_WRAPPERTYPEINFO();
public:
- static PassRefPtr<HTMLAnchorElement> create(Document&);
+ static PassRefPtr<HTMLViewElement> create(Document&);
- virtual ~HTMLAnchorElement();
+ virtual ~HTMLViewElement();
- KURL href() const;
- void setHref(const AtomicString&);
+private:
+ explicit HTMLViewElement(Document&);
- virtual bool isLiveLink() const override final;
+ virtual RenderObject* createRenderer(RenderStyle* style) override;
-private:
- explicit HTMLAnchorElement(Document&);
+ virtual void parseAttribute(const QualifiedName&, const AtomicString&) override;
+ virtual InsertionNotificationRequest insertedInto(ContainerNode*) override;
+ virtual void didNotifySubtreeInsertionsToDocument() override final;
+ virtual void removedFrom(ContainerNode*) override;
- virtual bool supportsFocus() const override final;
- virtual void defaultEventHandler(Event*) override final;
- virtual bool willRespondToMouseClickEvents() override final;
- virtual bool isURLAttribute(const Attribute&) const override final;
- virtual bool canStartSelection() const override final;
+private:
+ void setLocation(const String&);
+ void openURL();
- void handleClick(Event*);
+ AtomicString m_URL;
};
} // namespace blink
-#endif // HTMLAnchorElement_h
+#endif // HTMLViewElement_h

Powered by Google App Engine
This is Rietveld 408576698