Initial work on a new <view> element backed by a mojo::View.

sky/viewer/document_view.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sky/viewer/document_view.h"
 
 #include "base/bind.h"
 #include "base/location.h"
 #include "base/message_loop/message_loop_proxy.h"
 #include "base/single_thread_task_runner.h"
@@ skipping 133 matching lines @@
   shell_->ConnectToApplication("mojo:native_viewport_service",
                                mojo::GetProxy(&gpu_service_provider));
   mojo::InterfacePtr<mojo::Gpu> gpu_service;
   mojo::ConnectToService(gpu_service_provider.get(), &gpu_service);
   web_layer_tree_view_impl_.reset(new WebLayerTreeViewImpl(
       compositor_thread_, surfaces_service.Pass(), gpu_service.Pass()));
 
   return web_layer_tree_view_impl_.get();
 }
 
+void DocumentView::createChildView(const blink::WebURL& url,
+                                   const blink::WebRect& bounds) {
+  if (!root_)
+    return;
+
+  mojo::View* child = mojo::View::Create(root_->view_manager());
+  root_->AddChild(child);

[abarth-chromium, 2014/11/06 22:55:07]

Do we need to observe child so we can destroy it later?

[Matt Perry, 2014/11/06 23:38:50]

I must admit I don't understand the ownership here. Does root_ own its children?
Who owns root_? When we call child->Embed, a new DocumentView is created, whose
root_ node is for some reason different from child.

[Matt Perry, 2014/11/07 17:27:40]

Sky says we need to delete the children manually, because root_ here is a remote
View and will not delete children created locally here. I've added that below.

+  mojo::Rect mojo_bounds;
+  mojo_bounds.x = bounds.x;
+  mojo_bounds.y = bounds.y;
+  mojo_bounds.width = bounds.width;
+  mojo_bounds.height = bounds.height;
+  child->SetBounds(mojo_bounds);
+  child->Embed(mojo::String::From(url.string().utf8()));
+}
+
 void DocumentView::frameDetached(blink::WebFrame* frame) {
   // |frame| is invalid after here.
   frame->close();
 }
 
 blink::WebNavigationPolicy DocumentView::decidePolicyForNavigation(
     const blink::WebFrameClient::NavigationPolicyInfo& info) {
 
   navigator_host_->RequestNavigate(
       WebNavigationPolicyToNavigationTarget(info.defaultPolicy),
@@ skipping 47 matching lines @@
 
 void DocumentView::OnViewInputEvent(
     mojo::View* view, const mojo::EventPtr& event) {
   scoped_ptr<blink::WebInputEvent> web_event =
       event.To<scoped_ptr<blink::WebInputEvent> >();
   if (web_event)
     web_view_->handleInputEvent(*web_event);
 }
 
 }  // namespace sky