Initial work on a new <view> element backed by a mojo::View.

sky/engine/web/FrameLoaderClientImpl.cpp

 /*
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  * Copyright (C) 2011 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 19 matching lines @@
  */
 
 #include "config.h"
 #include "web/FrameLoaderClientImpl.h"
 
 #include "bindings/core/v8/ScriptController.h"
 #include "core/dom/Document.h"
 #include "core/events/MouseEvent.h"
 #include "core/frame/FrameView.h"
 #include "core/frame/Settings.h"
+#include "core/html/HTMLViewElement.h"
 #include "core/page/Chrome.h"
 #include "core/page/EventHandler.h"
 #include "core/page/Page.h"
 #include "core/rendering/HitTestResult.h"
 #include "platform/MIMETypeRegistry.h"
 #include "platform/RuntimeEnabledFeatures.h"
 #include "platform/UserGestureIndicator.h"
 #include "platform/exported/WrappedResourceRequest.h"
 #include "platform/exported/WrappedResourceResponse.h"
 #include "platform/network/HTTPParsers.h"
@@ skipping 193 matching lines @@
 void FrameLoaderClientImpl::loadURLExternally(const ResourceRequest& request, NavigationPolicy policy, const String& suggestedName)
 {
     if (m_webFrame->client()) {
         ASSERT(m_webFrame->frame()->document());
         WrappedResourceRequest webreq(request);
         m_webFrame->client()->loadURLExternally(
             m_webFrame, webreq, static_cast<WebNavigationPolicy>(policy), suggestedName);
     }
 }
 
+void FrameLoaderClientImpl::createView(const KURL& url, HTMLViewElement* ownerElement)
+{
+    if (m_webFrame->client()) {
+        WebRect bounds(ownerElement->offsetLeft(),
+                       ownerElement->offsetTop(),
+                       ownerElement->offsetWidth(),
+                       ownerElement->offsetHeight());

[esprehn, 2014/11/06 22:40:28]

You want clientLeft etc. not offset, your size doesn't respect padding.

[abarth-chromium, 2014/11/06 22:55:07]

Don't we need to wait until layout happens before this information is available?
 As written, this will cause a layout in the middle of constructing the DOM.

[Matt Perry, 2014/11/06 23:38:50]

Done.

+        m_webFrame->client()->createChildView(url, bounds);
+    }
+}
+
 void FrameLoaderClientImpl::selectorMatchChanged(const Vector<String>& addedSelectors, const Vector<String>& removedSelectors)
 {
     if (WebFrameClient* client = m_webFrame->client())
         client->didMatchCSS(m_webFrame, WebVector<WebString>(addedSelectors), WebVector<WebString>(removedSelectors));
 }
 
 // Called when the FrameLoader goes into a state in which a new page load
 // will occur.
 void FrameLoaderClientImpl::transitionToCommittedForNewPage()
 {
     m_webFrame->createFrameView();
 }
 
 void FrameLoaderClientImpl::didLoseWebGLContext(int arbRobustnessContextLostReason)
 {
     if (m_webFrame->client())
         m_webFrame->client()->didLoseWebGLContext(m_webFrame, arbRobustnessContextLostReason);
 }
 
 void FrameLoaderClientImpl::dispatchDidChangeManifest()
 {
     if (m_webFrame->client())
         m_webFrame->client()->didChangeManifest(m_webFrame);
 }
 
 } // namespace blink