Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java

Issue 7089017: Change source look-up design (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: clean Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java
diff --git a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java
index 90fd6ba3fd9e97d18f99b2a8c02c66a736b93666..e0fa708ffac07b4bbe2ef8c011d3a293cbeba57e 100644
--- a/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java
+++ b/plugins/org.chromium.debug.ui/src/org/chromium/debug/ui/actions/PushChangesAction.java
@@ -5,9 +5,12 @@
package org.chromium.debug.ui.actions;
import java.io.IOException;
+import java.util.Collection;
import java.util.List;
import org.chromium.debug.core.ChromiumDebugPlugin;
+import org.chromium.debug.core.model.VmResource;
+import org.chromium.debug.core.model.VmResource.ScriptHolder;
import org.chromium.debug.core.util.ChromiumDebugPluginUtil;
import org.chromium.debug.core.util.ScriptTargetMapping;
import org.chromium.debug.ui.liveedit.LiveEditDiffViewer;
@@ -60,8 +63,8 @@ public class PushChangesAction extends V8ScriptAction {
public static void execute(final ScriptTargetMapping filePair,
UpdatableScript.UpdateCallback callback, SyncCallback syncCallback, boolean previewOnly) {
- Script script = filePair.getScriptHolder().getSingleScript();
-
+ // TODO: fix the rough behavior (inside this call).
+ Script script = filePair.getSingleScript();
byte[] fileData;
try {
fileData = ChromiumDebugPluginUtil.readFileContents(filePair.getFile());

Powered by Google App Engine
This is Rietveld 408576698