Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VProjectWorkspaceBridge.java

Issue 7089017: Change source look-up design (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: fcr Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VProjectWorkspaceBridge.java
diff --git a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VProjectWorkspaceBridge.java b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VProjectWorkspaceBridge.java
index c91c66cb59918bb7e3055d65360a5a6fb36a6a2a..f7ae6c7b6d8e83160cf5b74f3ac5af415ed31165 100644
--- a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VProjectWorkspaceBridge.java
+++ b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/model/VProjectWorkspaceBridge.java
@@ -136,12 +136,13 @@ public class VProjectWorkspaceBridge implements WorkspaceBridge {
});
}
- public VmResource findVmResourceFromWorkspaceFile(IFile resource) throws CoreException {
+ public Collection<? extends VmResource> findVmResourceFromWorkspaceFile(IFile resource)
+ throws CoreException {
VmResourceId id = findVmResourceIdFromWorkspaceFile(resource);
if (id == null) {
return null;
}
- return resourceManager.getVmResource(id);
+ return Collections.singletonList(resourceManager.getVmResource(id));
}
public VmResource getVProjectVmResource(IFile file) {
@@ -158,7 +159,7 @@ public class VProjectWorkspaceBridge implements WorkspaceBridge {
}
private VmResourceId findVmResourceIdFromWorkspaceFile(IFile resource) throws CoreException {
- return sourceDirector.getReverseSourceLookup().findVmResource(resource);
+ return sourceDirector.findVmResource(resource);
}
public void reloadScript(Script script) {
@@ -445,7 +446,7 @@ public class VProjectWorkspaceBridge implements WorkspaceBridge {
if (script == null) {
scriptName = Messages.StackFrame_UnknownScriptName;
} else {
- scriptName = VmResourceId.forScript(script).getEclipseSourceName();
+ scriptName = VmResourceId.forScript(script).getVisibleName();
}
int line = stackFrame.getLineNumber();
if (line != -1) {

Powered by Google App Engine
This is Rietveld 408576698