Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(463)

Unified Diff: plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumDebugPlugin.java

Issue 7089017: Change source look-up design (Closed) Base URL: https://chromedevtools.googlecode.com/svn/trunk
Patch Set: fcr Created 9 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumSourceDirector.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumDebugPlugin.java
diff --git a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumDebugPlugin.java b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumDebugPlugin.java
index f5393ab367bb1eff06407b14dc95a0359a96a075..27b9887c11de59d7830aff88b116ebe6f6ef9081 100755
--- a/plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumDebugPlugin.java
+++ b/plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumDebugPlugin.java
@@ -6,6 +6,7 @@ package org.chromium.debug.core;
import java.text.MessageFormat;
import java.util.ArrayList;
+import java.util.Collection;
import java.util.List;
import java.util.logging.Handler;
import java.util.logging.Level;
@@ -94,21 +95,16 @@ public class ChromiumDebugPlugin extends Plugin {
new ArrayList<ScriptTargetMapping>(targetDataList.size());
for (ConnectedTargetData targetData : targetDataList) {
- VmResource script;
+ Collection<? extends VmResource> resources;
try {
- script = targetData.getVmResource(localFile);
+ resources = targetData.getVmResource(localFile);
} catch (CoreException e) {
throw new RuntimeException("Failed to resolve script from the file " + localFile, e);
}
- if (script == null) {
+ if (resources == null || resources.isEmpty()) {
continue;
}
- Metadata metadata = script.getMetadata();
- if (metadata instanceof VmResource.ScriptHolder == false) {
- continue;
- }
- VmResource.ScriptHolder scriptHolder = (VmResource.ScriptHolder) metadata;
- result.add(new ScriptTargetMapping(localFile, script, scriptHolder, targetData));
+ result.add(new ScriptTargetMapping(localFile, resources, targetData));
}
return result;
}
« no previous file with comments | « no previous file | plugins/org.chromium.debug.core/src/org/chromium/debug/core/ChromiumSourceDirector.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698