Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issue 7089010: Now that the macro-assembler functions are not templatized on (Closed)

Created:
9 years, 6 months ago by Erik Corry
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Now that the macro-assembler functions are not templatized on the two label classes they don't need to be inlined any more. This is a simple move of functions, no other refactors. TBR=vegorov Committed: http://code.google.com/p/v8/source/detail?r=8115

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -232 lines) Patch
M src/ia32/code-stubs-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/macro-assembler-ia32.h View 3 chunks +30 lines, -31 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 2 chunks +160 lines, -1 line 0 comments Download
D src/ia32/macro-assembler-ia32-inl.h View 1 chunk +0 lines, -198 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
9 years, 6 months ago (2011-05-30 18:57:09 UTC) #1
Vyacheslav Egorov (Chromium)
9 years, 6 months ago (2011-05-31 10:05:22 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698