Add support for shared library resources to java_apk build rules.

Add support for shared library resources to java_apk build rules.

BUG=430997
Committed: https://crrev.com/f90b7151cb809d8ec9ab31f7be9e9f8f575fd4d0
Cr-Commit-Position: refs/heads/master@{#303351}

[mkosiba (inactive), 2014-11-06 21:17:13]

mkosiba@chromium.org changed reviewers:
+ cjhopman@chromium.org

[mkosiba (inactive), 2014-11-06 21:17:14]

PTAL

[cjhopman, 2014-11-06 21:24:45]

Can we call this something other than "shared library" (afaik it isn't at all
related to static_library/shared_library).

Maybe "packaged library", "android packaged library", "library project", ...

[mkosiba (inactive), 2014-11-06 21:34:56]

On 2014/11/06 21:24:45, cjhopman wrote:
> Can we call this something other than "shared library" (afaik it isn't at all
> related to static_library/shared_library).
> 
> Maybe "packaged library", "android packaged library", "library project", ...

well, that's the name of the feature in Android :) --android-shared-resources ?

[cjhopman, 2014-11-06 21:42:20]

On 2014/11/06 21:34:56, mkosiba wrote:
> On 2014/11/06 21:24:45, cjhopman wrote:
> > Can we call this something other than "shared library" (afaik it isn't at
all
> > related to static_library/shared_library).
> > 
> > Maybe "packaged library", "android packaged library", "library project", ...
> 
> well, that's the name of the feature in Android :) --android-shared-resources
?

Do they call it that publicly? All I can find that seems similar is
https://developer.android.com/tools/projects/index.html which has something
about a "library project" and refers to it as a "Android library project".

Anyway, "android shared resources" is fine, as long as it doesn't contain both
shared and library I think it'll be fine.

[cjhopman, 2014-11-06 21:45:56]

https://codereview.chromium.org/708883003/diff/40001/build/android/gyp/proces...
File build/android/gyp/process_resources.py (right):

https://codereview.chromium.org/708883003/diff/40001/build/android/gyp/proces...
build/android/gyp/process_resources.py:44: help='Generate shared library
resources compatible R.java files.')
I would try to word the places where you say "shared library resources"
differently, but it's not entirely necessary.

https://codereview.chromium.org/708883003/diff/40001/build/android/gyp/proces...
build/android/gyp/process_resources.py:244:
package_command.append('--shared-lib')
s/shared-lib/shared-resources

https://codereview.chromium.org/708883003/diff/40001/build/config/android/int...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/708883003/diff/40001/build/config/android/int...
build/config/android/internal_rules.gni:723: args += ["--shared_resources"]
s/shared_res/shared-res

https://codereview.chromium.org/708883003/diff/40001/build/config/android/rul...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/708883003/diff/40001/build/config/android/rul...
build/config/android/rules.gni:525: shared_resources = invokershared_resources.
s/invokershared_resources\./invoker.shared_resources

[mkosiba (inactive), 2014-11-06 22:11:38]

sorry for the chaotic patchset, doing to many things at the same time.

https://codereview.chromium.org/708883003/diff/40001/build/android/gyp/proces...
File build/android/gyp/process_resources.py (right):

https://codereview.chromium.org/708883003/diff/40001/build/android/gyp/proces...
build/android/gyp/process_resources.py:44: help='Generate shared library
resources compatible R.java files.')
On 2014/11/06 21:45:56, cjhopman wrote:
> I would try to word the places where you say "shared library resources"
> differently, but it's not entirely necessary.

I can take the docs from aapt:

Make a resource package that can be loaded by a different application
at runtime to access the package's resources.

https://codereview.chromium.org/708883003/diff/40001/build/android/gyp/proces...
build/android/gyp/process_resources.py:244:
package_command.append('--shared-lib')
On 2014/11/06 21:45:56, cjhopman wrote:
> s/shared-lib/shared-resources

sorry, that's the name of the argument that aapt takes :)

https://codereview.chromium.org/708883003/diff/40001/build/config/android/int...
File build/config/android/internal_rules.gni (right):

https://codereview.chromium.org/708883003/diff/40001/build/config/android/int...
build/config/android/internal_rules.gni:723: args += ["--shared_resources"]
On 2014/11/06 21:45:56, cjhopman wrote:
> s/shared_res/shared-res

Done.

https://codereview.chromium.org/708883003/diff/40001/build/config/android/rul...
File build/config/android/rules.gni (right):

https://codereview.chromium.org/708883003/diff/40001/build/config/android/rul...
build/config/android/rules.gni:525: shared_resources = invokershared_resources.
On 2014/11/06 21:45:56, cjhopman wrote:
> s/invokershared_resources\./invoker.shared_resources

yeath, search/replace fail...

[mkosiba (inactive), 2014-11-06 23:19:40]

ok, the latest patchset should be good, ptal

[cjhopman, 2014-11-08 00:58:57]

lgtm

[mkosiba (inactive), 2014-11-08 01:01:22]

On 2014/11/08 00:58:57, cjhopman wrote:
> lgtm

many thanks!

[mkosiba (inactive), 2014-11-08 01:01:25]

The CQ bit was checked by mkosiba@chromium.org

[commit-bot: I haz the power, 2014-11-08 01:02:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/708883003/70006

[commit-bot: I haz the power, 2014-11-08 02:08:50]

Committed patchset #5 (id:70006)

[commit-bot: I haz the power, 2014-11-08 02:09:24]

Patchset 5 (id:??) landed as
https://crrev.com/f90b7151cb809d8ec9ab31f7be9e9f8f575fd4d0
Cr-Commit-Position: refs/heads/master@{#303351}