Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 708843002: Remove -webkit-auto, -webkit-center, -webkit-left, -webkit-right. (Closed)

Created:
6 years, 1 month ago by ojan
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Remove -webkit-auto, -webkit-center, -webkit-left, -webkit-right. These are values for text-align that align blocks in addition to inline content. You can get the same centering affect with margin:auto. If we want this functionality, we should implement it with the same alignment APIs that we use for flexbox. Delete unused methods/arguments from RenderBlockFlow. No change in behavior. Just deleting dead code. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/e223e0c6d51f027196a2597b556641328a65d4b5

Patch Set 1 #

Patch Set 2 : merge to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -38 lines) Patch
M sky/engine/core/css/CSSPrimitiveValueMappings.h View 2 chunks +0 lines, -10 lines 0 comments Download
M sky/engine/core/css/CSSValueKeywords.in View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/css/parser/CSSPropertyParser.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/engine/core/editing/EditingStyle.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockFlow.cpp View 1 1 chunk +1 line, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBlockLineLayout.cpp View 1 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderBox.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download
M sky/engine/core/rendering/RenderBoxModelObject.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/RenderText.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M sky/engine/core/rendering/style/RenderStyleConstants.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
ojan
6 years, 1 month ago (2014-11-06 19:52:45 UTC) #1
esprehn
lgtm
6 years, 1 month ago (2014-11-06 19:55:19 UTC) #3
ojan
6 years, 1 month ago (2014-11-06 19:55:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e223e0c6d51f027196a2597b556641328a65d4b5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698