Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 708823002: Streaming API: detect UTF-8 BOM. (Closed)

Created:
6 years, 1 month ago by marja
Modified:
6 years, 1 month ago
Reviewers:
Yang
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Streaming API: detect UTF-8 BOM. It used to cause lazy function positions to be off by one. BUG=430890 LOG=N

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -18 lines) Patch
M src/scanner-character-streams.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/scanner-character-streams.cc View 1 5 chunks +24 lines, -15 lines 0 comments Download
M test/cctest/test-api.cc View 1 2 3 chunks +40 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
marja
yangguo@, I'm having fun with UTF-8 again. Ptal.
6 years, 1 month ago (2014-11-07 09:16:34 UTC) #2
Yang
6 years, 1 month ago (2014-11-07 10:26:13 UTC) #3
On 2014/11/07 09:16:34, marja wrote:
> yangguo@, I'm having fun with UTF-8 again. Ptal.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698