Issue 708803002: minidump: stronger checking for MinidumpWritableAtRVA<>()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 708803002: minidump: stronger checking for MinidumpWritableAtRVA<>() (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

minidump: stronger checking for MinidumpWritableAtRVA<>(). MinidumpWritableAtRVA<>() now checks that the object of the requested type is actually in the range of the minidump file’s size, rather than just checking that the beginning of the object is in range. TEST=minidump_test R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/8ad3beccdb56e5214ec5a82497bc90e09902ec2b

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -36 lines)			Patch
	M	minidump/test/minidump_writable_test_util.h	View		4 chunks	+20 lines, -36 lines	0 comments	Download
	M	minidump/test/minidump_writable_test_util.cc	View		2 chunks	+16 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Mark Mentovai

6 years, 1 month ago (2014-11-06 21:48:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
8ad3beccdb56e5214ec5a82497bc90e09902ec2b (presubmit successful).