Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Unified Diff: pkg/analyzer2dart/lib/src/cps_generator.dart

Issue 708793002: Revert "dart2js: Add a type parameter to class Reference in the CPS IR." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/constant_propagation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer2dart/lib/src/cps_generator.dart
diff --git a/pkg/analyzer2dart/lib/src/cps_generator.dart b/pkg/analyzer2dart/lib/src/cps_generator.dart
index d2c6b224551b6b9cf247ca78612d415a80156607..905e60885898d08e2304c3bff4a07195fedc74f0 100644
--- a/pkg/analyzer2dart/lib/src/cps_generator.dart
+++ b/pkg/analyzer2dart/lib/src/cps_generator.dart
@@ -57,10 +57,10 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
});
}
- List<ir.Primitive> visitArguments(ArgumentList argumentList) {
- List<ir.Primitive> arguments = <ir.Primitive>[];
+ List<ir.Definition> visitArguments(ArgumentList argumentList) {
+ List<ir.Definition> arguments = <ir.Definition>[];
for (Expression argument in argumentList.arguments) {
- ir.Primitive value = build(argument);
+ ir.Definition value = build(argument);
if (value == null) {
giveUp(argument,
'Unsupported argument: $argument (${argument.runtimeType}).');
@@ -81,7 +81,7 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
AccessSemantics semantics) {
// TODO(johnniwinther): Handle implicit `this`.
ir.Primitive receiver = build(semantics.target);
- List<ir.Primitive> arguments = visitArguments(node.argumentList);
+ List<ir.Definition> arguments = visitArguments(node.argumentList);
return irBuilder.buildDynamicInvocation(
receiver,
createSelectorFromMethodInvocation(
@@ -94,7 +94,7 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
AccessSemantics semantics) {
analyzer.Element staticElement = semantics.element;
dart2js.Element element = converter.convertElement(staticElement);
- List<ir.Primitive> arguments = visitArguments(node.argumentList);
+ List<ir.Definition> arguments = visitArguments(node.argumentList);
return irBuilder.buildStaticInvocation(
element,
createSelectorFromMethodInvocation(
@@ -109,7 +109,7 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
if (staticElement != null) {
dart2js.Element element = converter.convertElement(staticElement);
dart2js.DartType type = converter.convertType(node.staticType);
- List<ir.Primitive> arguments = visitArguments(node.argumentList);
+ List<ir.Definition> arguments = visitArguments(node.argumentList);
String name = '';
if (node.constructorName.name != null) {
name = node.constructorName.name.name;
@@ -258,7 +258,7 @@ class CpsGeneratingVisitor extends SemanticVisitor<ir.Node>
ir.Primitive right = build(node.rightOperand);
Selector selector = new Selector.binaryOperator(op);
return irBuilder.buildDynamicInvocation(
- left, selector, <ir.Primitive>[right]);
+ left, selector, <ir.Definition>[right]);
}
ir.Node handleLazyOperator(BinaryExpression node, {bool isLazyOr: false}) {
« no previous file with comments | « no previous file | pkg/compiler/lib/src/cps_ir/constant_propagation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698