Update base::BindBlock for three parameters.

Update base::BindBlock for three parameters.

BUG=

Committed: https://crrev.com/b239b09167bc7b53f4c0ff46bd10b3c057d569c4
Cr-Commit-Position: refs/heads/master@{#303295}

[marq (ping after 24h), 2014-11-06 11:59:39]

marq@chromium.org changed reviewers:
+ thakis@chromium.org

[Nico, 2014-11-06 17:44:47]

https://codereview.chromium.org/708743002/diff/1/base/mac/bind_objc_block.h
File base/mac/bind_objc_block.h (right):

https://codereview.chromium.org/708743002/diff/1/base/mac/bind_objc_block.h#n...
base/mac/bind_objc_block.h:51: return extracted_block(a, b, c);
Can you make RunBlock() a variadic template? Then it'll work with all numbers of
parameters.

Something like:

template<typename R, typename... Args>
R RunBlock(base::mac::ScopedBlock<R(^)(Args...)> block, Args...) {
  return block.get()(Args..);
}

(untested, I probably screwed up the syntax somewhere.)

[marq (ping after 24h), 2014-11-07 09:00:56]

Cool!

Done, PTAL.

https://codereview.chromium.org/708743002/diff/1/base/mac/bind_objc_block.h
File base/mac/bind_objc_block.h (right):

https://codereview.chromium.org/708743002/diff/1/base/mac/bind_objc_block.h#n...
base/mac/bind_objc_block.h:51: return extracted_block(a, b, c);
On 2014/11/06 17:44:47, Nico wrote:
> Can you make RunBlock() a variadic template? Then it'll work with all numbers
of
> parameters.
> 
> Something like:
> 
> template<typename R, typename... Args>
> R RunBlock(base::mac::ScopedBlock<R(^)(Args...)> block, Args...) {
>   return block.get()(Args..);
> }
> 
> (untested, I probably screwed up the syntax somewhere.)

Done, and BindBlock() is now also variadic.

[Nico, 2014-11-07 18:11:23]

lgtm

https://codereview.chromium.org/708743002/diff/20001/base/mac/bind_objc_block.h
File base/mac/bind_objc_block.h (right):

https://codereview.chromium.org/708743002/diff/20001/base/mac/bind_objc_block...
base/mac/bind_objc_block.h:29: // zero through six arguments.
(fwiw, bind / callback are going to use this too –
https://codereview.chromium.org/610423003/ – but we're sorting sometoolchain
issues first)

[marq (ping after 24h), 2014-11-07 20:30:16]

The CQ bit was checked by marq@chromium.org

[commit-bot: I haz the power, 2014-11-07 20:31:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/708743002/20001

[commit-bot: I haz the power, 2014-11-07 21:20:23]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-07 21:20:59]

Patchset 2 (id:??) landed as
https://crrev.com/b239b09167bc7b53f4c0ff46bd10b3c057d569c4
Cr-Commit-Position: refs/heads/master@{#303295}