Source/modules/serviceworkers/CacheTest.cpp - Issue 708703002: Service Worker: Cache.put() consumes request/response bodies

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/serviceworkers/CacheTest.cpp

Issue 708703002: Service Worker: Cache.put() consumes request/response bodies (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use Response bodies too, but only Request bodies if non-empty Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/serviceworkers/CacheTest.cpp

diff --git a/Source/modules/serviceworkers/CacheTest.cpp b/Source/modules/serviceworkers/CacheTest.cpp

index 0520a4e07a639e9da68878c752fb31e205774632..af71c8875d98dea20d9f43c7ba32634b098cfb6a 100644

--- a/Source/modules/serviceworkers/CacheTest.cpp

+++ b/Source/modules/serviceworkers/CacheTest.cpp

@@ -398,7 +398,7 @@ TEST_F(ServiceWorkerCacheTest, BatchOperationArguments)

request = newRequestFromUrl(url);

ASSERT(request);

- ScriptPromise putResult = cache->put(scriptState(), request, response);

+ ScriptPromise putResult = cache->put(scriptState(), request, response->clone(), exceptionState());

EXPECT_EQ("dispatchBatch", testCache->getAndClearLastErrorWebCacheMethodCalled());

EXPECT_EQ(kNotImplementedString, getRejectString(putResult));