Service Worker: Cache.put() consumes request/response bodies

Source/modules/serviceworkers/Body.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef Body_h
 #define Body_h
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/ScriptWrappable.h"
@@ skipping 25 matching lines @@
         ResponseAsJSON,
         ResponseAsText
     };
 
     ScriptPromise arrayBuffer(ScriptState*);
     ScriptPromise blob(ScriptState*);
     ScriptPromise formData(ScriptState*);
     ScriptPromise json(ScriptState*);
     ScriptPromise text(ScriptState*);
 
+    // Sets the bodyUsed flag to true. This signifies that the contents of the
+    // body have been consumed and cannot be accessed again.
+    void setBodyUsed();

[gavinp, 2014/11/13 19:35:02]

Should we put this after bodyUsed() so the order matches that of Body.cc? I'm a
huge fan of definition order following declaration order. Blink coding style
doesn't discuss this, although Chromium and Google C++ style is for definition
order to follow declaration order.

Better yet, why not just inline these?

[jsbell, 2014/11/13 21:16:05]

Inlined, to minimize diff.

     bool bodyUsed() const;
 
     // ActiveDOMObject override.
     virtual void stop() override;
     virtual bool hasPendingActivity() const override;
 
     virtual void trace(Visitor*) { }
 
 protected:
     // Copy constructor for clone() implementations
     explicit Body(const Body&);
 
-    // Sets the bodyUsed flag to true. This signifies that the contents of the
-    // body have been consumed and cannot be accessed again.
-    void setBodyUsed();
-
 private:
     ScriptPromise readAsync(ScriptState*, ResponseType);
     void resolveJSON();
 
     // FileReaderLoaderClient functions.
     virtual void didStartLoading() override;
     virtual void didReceiveData() override;
     virtual void didFinishLoading() override;
     virtual void didFail(FileError::ErrorCode) override;
 
     virtual PassRefPtr<BlobDataHandle> blobDataHandle() = 0;
 
     OwnPtr<FileReaderLoader> m_loader;
     bool m_bodyUsed;
     ResponseType m_responseType;
     RefPtr<ScriptPromiseResolver> m_resolver;
 };
 
 } // namespace blink
 
 #endif // Body_h