Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Issue 708663003: MIPS: Skip embenchen tests on big-endian. (Closed)

Created:
6 years, 1 month ago by paul.l...
Modified:
6 years, 1 month ago
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

MIPS: Skip embenchen tests on big-endian. Emscripten requires little-endian arch. It has assertion for endianness: assert(HEAPU8[0] === 255 && HEAPU8[3] === 0, 'Typed arrays 2 must be run on a little-endian system'); TEST=mjsunit/asm/embenchen/* BUG= R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25177

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M test/mjsunit/mjsunit.status View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
paul.l...
PTAL.
6 years, 1 month ago (2014-11-06 02:30:23 UTC) #2
Benedikt Meurer
lgtm
6 years, 1 month ago (2014-11-06 06:17:59 UTC) #3
Benedikt Meurer
6 years, 1 month ago (2014-11-06 06:18:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 25177 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698