Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Issue 708633002: Add city-list example tests to sky (Closed)

Created:
6 years, 1 month ago by rafaelw
Modified:
6 years, 1 month ago
CC:
abarth-chromium, esprehn, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : this #

Patch Set 3 : working #

Patch Set 4 : working #

Unified diffs Side-by-side diffs Delta from patch set Stats (+551 lines, -9 lines) Patch
M sky/examples/city-list/city-list.sky View 1 2 3 6 chunks +18 lines, -9 lines 0 comments Download
A sky/tests/framework/citylist.sky View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A sky/tests/framework/citylist-expected.txt View 1 2 1 chunk +259 lines, -0 lines 0 comments Download
A sky/tests/framework/citylist-scrolled.sky View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A sky/tests/framework/citylist-scrolled-expected.txt View 1 2 3 1 chunk +245 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
rafaelw
6 years, 1 month ago (2014-11-06 01:28:01 UTC) #2
abarth-chromium
lgtm
6 years, 1 month ago (2014-11-06 01:55:31 UTC) #4
rafaelw
6 years, 1 month ago (2014-11-06 01:59:24 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
da4bc8b218ba63825a3807e165cbf9079665d391 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698