Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Issue 7086017: Fix the loading of ca@valencia.pak, which is available in (Closed)

Created:
9 years, 7 months ago by tony
Modified:
9 years, 6 months ago
CC:
chromium-reviews, PaweĊ‚ Hajdan Jr., jshin+watch_chromium.org, brettw-cc_chromium.org, fta
Visibility:
Public.

Description

Fix the loading of ca@valencia.pak, which is available in Ubuntu's chromium-browser package. We weren't handling language variant at all. BUG=83397 TEST=Covered by new unittests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88043

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix comment #

Patch Set 3 : test fix #

Patch Set 4 : one less line #

Total comments: 1

Patch Set 5 : fix comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -7 lines) Patch
M base/i18n/rtl.cc View 1 2 3 4 2 chunks +9 lines, -1 line 0 comments Download
M ui/base/l10n/l10n_util.cc View 1 2 chunks +14 lines, -6 lines 0 comments Download
M ui/base/l10n/l10n_util_unittest.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tony
9 years, 7 months ago (2011-05-28 01:20:33 UTC) #1
James Su
http://codereview.chromium.org/7086017/diff/1/ui/base/l10n/l10n_util.cc File ui/base/l10n/l10n_util.cc (right): http://codereview.chromium.org/7086017/diff/1/ui/base/l10n/l10n_util.cc#newcode268 ui/base/l10n/l10n_util.cc:268: return false; If I understand correctly, this fix implies ...
9 years, 6 months ago (2011-05-30 02:00:49 UTC) #2
jungshik at Google
I guess our locale pick-up code has to be rewritten along the line of what's ...
9 years, 6 months ago (2011-05-31 09:23:52 UTC) #3
tony
On 2011/05/30 02:00:49, James Su wrote: > http://codereview.chromium.org/7086017/diff/1/ui/base/l10n/l10n_util.cc > File ui/base/l10n/l10n_util.cc (right): > > http://codereview.chromium.org/7086017/diff/1/ui/base/l10n/l10n_util.cc#newcode268 ...
9 years, 6 months ago (2011-05-31 19:30:05 UTC) #4
James Su
LGTM. On 2011/05/31 19:30:05, tony wrote: > On 2011/05/30 02:00:49, James Su wrote: > > ...
9 years, 6 months ago (2011-06-01 02:23:09 UTC) #5
tony
On 2011/05/31 09:23:52, Jungshik Shin wrote: > I guess our locale pick-up code has to ...
9 years, 6 months ago (2011-06-02 00:06:30 UTC) #6
tony
+base owners
9 years, 6 months ago (2011-06-06 21:26:06 UTC) #7
Evan Martin
9 years, 6 months ago (2011-06-06 21:27:39 UTC) #8
LGTM

http://codereview.chromium.org/7086017/diff/12001/base/i18n/rtl.cc
File base/i18n/rtl.cc (right):

http://codereview.chromium.org/7086017/diff/12001/base/i18n/rtl.cc#newcode23
base/i18n/rtl.cc:23: // Extract language and country, ignore keywords,
concatenate using dash.
This comment is no longer accurate.

Powered by Google App Engine
This is Rietveld 408576698