chromeos/dbus/fake_shill_manager_client.cc - Issue 708563005: Use setProperties for IP Config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/dbus/fake_shill_manager_client.cc

Issue 708563005: Use setProperties for IP Config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_1

Patch Set: IPConfigType=Static applies to NameServer only config Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/extensions/api_test/networking/test.js ('K') | « chrome/test/data/extensions/api_test/networking/test.js ('k') | chromeos/network/client_cert_resolver_unittest.cc » ('j') | chromeos/network/network_configuration_handler.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromeos/dbus/fake_shill_manager_client.cc

diff --git a/chromeos/dbus/fake_shill_manager_client.cc b/chromeos/dbus/fake_shill_manager_client.cc

index 2ef8327d0f07f07938ce013adbe012d8bfc41dc1..53c8216c209e40aca113efb713c43d68626bb665 100644

--- a/chromeos/dbus/fake_shill_manager_client.cc

+++ b/chromeos/dbus/fake_shill_manager_client.cc

@@ -596,7 +596,7 @@ void FakeShillManagerClient::SetupDefaultEnvironment() {

ipconfig_v4_dictionary.SetStringWithoutPathExpansion(

shill::kGatewayProperty, "0.0.0.1");

ipconfig_v4_dictionary.SetIntegerWithoutPathExpansion(

- shill::kPrefixlenProperty, 0);

+ shill::kPrefixlenProperty, 1);

pneubeck (no reviews) 2014/12/05 09:47:46 how is this change relevant?

stevenjb 2015/01/08 00:44:39 0 is not valid. I rely on the fake implementation

ipconfig_v4_dictionary.SetStringWithoutPathExpansion(

shill::kMethodProperty, shill::kTypeIPv4);

ip_configs->AddIPConfig("ipconfig_v4_path", ipconfig_v4_dictionary);