chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc - Issue 708563005: Use setProperties for IP Config.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

Issue 708563005: Use setProperties for IP Config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_1

Patch Set: IPConfigType=Static applies to NameServer only config Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/resources/options/chromeos/internet_detail.html » ('j') | chrome/browser/resources/options/chromeos/internet_detail.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

diff --git a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

index a2b706e8dca40621e0ea5f0dc6abb90e5b3191ea..80902606544bea2b64ce6997b8691dbc4b3ee245 100644

--- a/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

+++ b/chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc

@@ -270,13 +270,18 @@ class NetworkingPrivateChromeOSApiTest : public ExtensionApiTest {

service_test_->SetServiceProperty("stub_wifi1",

shill::kDeviceProperty,

base::StringValue(kWifiDevicePath));

- profile_test->AddService(kUser1ProfilePath, "stub_wifi1");

+ base::DictionaryValue static_ipconfig;

+ static_ipconfig.SetStringWithoutPathExpansion(shill::kAddressProperty,

+ "1.2.3.4");

+ service_test_->SetServiceProperty(

+ "stub_wifi1", shill::kStaticIPConfigProperty, static_ipconfig);

base::ListValue frequencies1;

frequencies1.AppendInteger(2400);

service_test_->SetServiceProperty(

"stub_wifi1", shill::kWifiFrequencyListProperty, frequencies1);

service_test_->SetServiceProperty(

"stub_wifi1", shill::kWifiFrequency, base::FundamentalValue(2400));

+ profile_test->AddService(kUser1ProfilePath, "stub_wifi1");

AddService("stub_wifi2", "wifi2_PSK", shill::kTypeWifi, shill::kStateIdle);

service_test_->SetServiceProperty("stub_wifi2",