chromeos/test/data/network/translation_of_shill_ethernet.onc - Issue 708563005: Use setProperties for IP Config.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chromeos/test/data/network/translation_of_shill_ethernet.onc

Issue 708563005: Use setProperties for IP Config. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@issue_430113_internet_options_1

Patch Set: IPConfigType=Static applies to NameServer only config Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chromeos/network/onc/onc_translator_shill_to_onc.cc ('K') | « chromeos/network/onc/onc_translator_shill_to_onc.cc ('k') | chromeos/test/data/network/translation_of_shill_ethernet_with_ipconfig.onc » ('j') | components/onc/docs/onc_spec.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 {	1 {

2 "Ethernet":{	2 "Ethernet":{

3 "Authentication":"None"	3 "Authentication":"None"

4 },	4 },

5 "GUID":"guid",	5 "GUID":"guid",

	6 "IPConfigType":"Static",

6 "Name":"",	7 "Name":"",

7 "StaticIPConfig":{	8 "StaticIPConfig":{

8 "Gateway":"1.1.1.7",	9 "Gateway":"1.1.1.7",

9 "IPAddress":"125.125.125.125",	10 "IPAddress":"125.125.125.125",

10 "NameServers":[	11 "NameServers":[

11 "1.1.1.8",	12 "1.1.1.8",

12 "125.1.1.3"	13 "125.1.1.3"

13 ],	14 ],

14 "RoutingPrefix":26,	15 "RoutingPrefix":26,

15 "Type":"IPv4"	16 "Type":"IPv4"

16 },	17 },

17 "Type":"Ethernet"	18 "Type":"Ethernet"

18 }	19 }

OLD	NEW