Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 708563002: Move mojo/public/js/bindings/ moves to mojo/public/js/ (Closed)

Created:
6 years, 1 month ago by hansmuller
Modified:
6 years, 1 month ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, esprehn, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Move mojo/public/js/bindings/ to mojo/public/js/. This is the first set of moves described in crbug.com/430520 BUG=430520 R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/96c6909393bd8e4398442efcd9d9f849d54ee978

Patch Set 1 #

Patch Set 2 : Sync #

Patch Set 3 : Sync again #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -3208 lines) Patch
M mojo/apps/js/bindings/connection_unittests.js View 2 chunks +4 lines, -4 lines 0 comments Download
M mojo/apps/js/main.js View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/apps/js/mojo.js View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/apps/js/test/js_to_cpp_unittest.js View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/bindings/js/core.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/support.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/bindings/js/tests/run_js_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
D mojo/public/js/bindings/BUILD.gn View 1 chunk +0 lines, -10 lines 0 comments Download
D mojo/public/js/bindings/buffer.js View 1 chunk +0 lines, -156 lines 0 comments Download
D mojo/public/js/bindings/codec.js View 1 chunk +0 lines, -792 lines 0 comments Download
D mojo/public/js/bindings/codec_unittests.js View 1 chunk +0 lines, -258 lines 0 comments Download
D mojo/public/js/bindings/connection.js View 1 chunk +0 lines, -58 lines 0 comments Download
D mojo/public/js/bindings/connector.js View 1 chunk +0 lines, -129 lines 0 comments Download
D mojo/public/js/bindings/constants.h View 1 chunk +0 lines, -21 lines 0 comments Download
D mojo/public/js/bindings/constants.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D mojo/public/js/bindings/core.js View 1 chunk +0 lines, -229 lines 0 comments Download
D mojo/public/js/bindings/core_unittests.js View 1 chunk +0 lines, -133 lines 0 comments Download
D mojo/public/js/bindings/router.js View 1 chunk +0 lines, -138 lines 0 comments Download
D mojo/public/js/bindings/struct_unittests.js View 1 chunk +0 lines, -169 lines 0 comments Download
D mojo/public/js/bindings/support.js View 1 chunk +0 lines, -30 lines 0 comments Download
D mojo/public/js/bindings/tests/validation_test_input_parser.js View 1 chunk +0 lines, -299 lines 0 comments Download
D mojo/public/js/bindings/unicode.js View 1 chunk +0 lines, -51 lines 0 comments Download
D mojo/public/js/bindings/validation_unittests.js View 1 chunk +0 lines, -302 lines 0 comments Download
D mojo/public/js/bindings/validator.js View 1 chunk +0 lines, -356 lines 0 comments Download
A + mojo/public/js/buffer.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/codec.js View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/public/js/codec_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/connection.js View 1 chunk +3 lines, -3 lines 0 comments Download
A + mojo/public/js/connector.js View 1 chunk +5 lines, -5 lines 0 comments Download
A + mojo/public/js/constants.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A mojo/public/js/constants.cc View 1 chunk +17 lines, -0 lines 0 comments Download
A + mojo/public/js/core.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/core_unittests.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/router.js View 1 chunk +4 lines, -4 lines 0 comments Download
A + mojo/public/js/struct_unittests.js View 1 chunk +2 lines, -2 lines 0 comments Download
A + mojo/public/js/support.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/test/validation_test_input_parser.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/unicode.js View 1 chunk +1 line, -1 line 0 comments Download
A + mojo/public/js/validation_unittests.js View 1 chunk +8 lines, -8 lines 0 comments Download
A + mojo/public/js/validator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M mojo/public/sky/BUILD.gn View 1 chunk +7 lines, -7 lines 0 comments Download
M mojo/public/sky/convert_amd_modules_to_sky.py View 1 chunk +1 line, -1 line 0 comments Download
M mojo/public/tools/bindings/generators/js_templates/module.amd.tmpl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
jamesr
lgtm
6 years, 1 month ago (2014-11-05 21:06:54 UTC) #2
hansmuller
6 years, 1 month ago (2014-11-05 21:11:54 UTC) #3
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
96c6909393bd8e4398442efcd9d9f849d54ee978 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698