Delete the unused WebPushPermissionCallback [3/3]

Delete the unused WebPushPermissionCallback [3/3]

Patch dependency:
[1] Blink: https://crrev.com/702003004/
[2] Chromium: https://crrev.com/690833004/
[3] Blink: https://crrev.com/708543002/ (THIS PATCH)

BUG=430527
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184919

[Michael van Ouwerkerk, 2014-11-05 17:29:46]

mvanouwerkerk@chromium.org changed reviewers:
+ mkwst@chromium.org

[Michael van Ouwerkerk, 2014-11-05 17:29:46]

Hi Mike, could you take a look please? Thanks!

[Mike West, 2014-11-05 18:37:06]

LGTM, once the other patches land.

[Mike West, 2014-11-05 18:38:08]

Would you mind adding links to all three patches in each of the CL descriptions?
I find the way horo@ does this to be really nicely readable:
https://codereview.chromium.org/697593002/

[Michael van Ouwerkerk, 2014-11-06 10:49:36]

On 2014/11/05 18:38:08, Mike West wrote:
> Would you mind adding links to all three patches in each of the CL
descriptions?
> I find the way horo@ does this to be really nicely readable:
> https://codereview.chromium.org/697593002/

Agreed that's nicer. Done!

[Mike West, 2014-11-06 11:39:28]

Thanks, still LGTM. :)

[Michael van Ouwerkerk, 2014-11-06 15:03:00]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2014-11-06 15:03:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/708543002/1

[commit-bot: I haz the power, 2014-11-06 15:03:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-11-06 15:03:45]

Failed to apply patch for public/platform/WebPushClient.h:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file public/platform/WebPushClient.h
  Hunk #2 FAILED at 27.
  1 out of 2 hunks FAILED -- saving rejects to file
public/platform/WebPushClient.h.rej

Patch:       public/platform/WebPushClient.h
Index: public/platform/WebPushClient.h
diff --git a/public/platform/WebPushClient.h b/public/platform/WebPushClient.h
index
c8f333261086b2bf942307965051d9296e5e93ee..874206a7fae9854dec2979d859b26aeebc8a7ca6
100644
--- a/public/platform/WebPushClient.h
+++ b/public/platform/WebPushClient.h
@@ -15,8 +15,6 @@ class WebServiceWorkerProvider;
 struct WebPushRegistration;
 
 typedef WebCallbacks<WebPushRegistration, WebPushError>
WebPushRegistrationCallbacks;
-// FIXME: Delete WebPushPermissionCallback once the embedder stops depending on
it.
-typedef WebCallbacks<WebPushPermissionStatus, void> WebPushPermissionCallback;
 typedef WebCallbacks<WebPushPermissionStatus, void>
WebPushPermissionStatusCallback;
 
 class WebPushClient {
@@ -29,7 +27,7 @@ public:
 
     // Ownership of the WebPushPermissionStatusCallback is transferred to the
     // client. Ownership of the WebServiceWorkerProvider is not transferred.
-    virtual void getPermissionStatus(WebPushPermissionStatusCallback*,
WebServiceWorkerProvider*) {}
+    virtual void getPermissionStatus(WebPushPermissionStatusCallback*,
WebServiceWorkerProvider*) { }
 };
 
 } // namespace blink

[Michael van Ouwerkerk, 2014-11-06 15:08:16]

The CQ bit was checked by mvanouwerkerk@chromium.org

[commit-bot: I haz the power, 2014-11-06 15:08:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/708543002/20001

[commit-bot: I haz the power, 2014-11-06 16:12:01]

Committed patchset #2 (id:20001) as 184919