Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 708513002: Allow Objective-C interfaces in //base/ios (Closed)

Created:
6 years, 1 month ago by droger
Modified:
6 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow Objective-C interfaces in //base/ios Objective-C interfaces are disallowed in base because of a bug related to plugins. There are no plugins on iOS, and //base/ios is not compiled for other platforms. Committed: https://crrev.com/114a60b29b034a2d658738aae08ec889d6a6b866 Cr-Commit-Position: refs/heads/master@{#303007}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M base/PRESUBMIT.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
droger
6 years, 1 month ago (2014-11-05 16:34:09 UTC) #2
droger
The motivation for this change is that I would like to upstream our WeakNSObject class ...
6 years, 1 month ago (2014-11-05 16:36:08 UTC) #3
stuartmorgan
On 2014/11/05 16:36:08, droger wrote: > I am not sure if WeakNSObject would be useful ...
6 years, 1 month ago (2014-11-05 16:50:49 UTC) #4
Nico
lgtm if you folks want to do this. I weakly feel that making it harder ...
6 years, 1 month ago (2014-11-05 17:05:45 UTC) #5
droger
I'd be in favor of landing this presubmit change. For WeakNSObject, I don't have a ...
6 years, 1 month ago (2014-11-06 10:01:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708513002/1
6 years, 1 month ago (2014-11-06 10:02:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 1 month ago (2014-11-06 11:06:59 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-06 11:07:39 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/114a60b29b034a2d658738aae08ec889d6a6b866
Cr-Commit-Position: refs/heads/master@{#303007}

Powered by Google App Engine
This is Rietveld 408576698