Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Unified Diff: runtime/vm/flow_graph_type_propagator.cc

Issue 708493002: Landing bug fix in type propagation. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_type_propagator.cc
===================================================================
--- runtime/vm/flow_graph_type_propagator.cc (revision 41519)
+++ runtime/vm/flow_graph_type_propagator.cc (working copy)
@@ -548,14 +548,12 @@
if (type_ == NULL) {
ASSERT(cid_ != kIllegalCid);
- // VM internal Function and Context objects don't have a compile-type.
- // Return dynamic-type in this case.
- if (cid_ == kFunctionCid || cid_ == kContextCid) {
+ // VM-internal objects don't have a compile-type. Return dynamic-type
+ // in this case.
+ if (cid_ < kInstanceCid) {
type_ = &Type::ZoneHandle(Type::DynamicType());
return type_;
}
- // Except the special cases above, only instances are expected.
- ASSERT(cid_ >= kInstanceCid);
const Class& type_class =
Class::Handle(Isolate::Current()->class_table()->At(cid_));
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698