Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 708483003: Allow Windows to use system Vsync for a single window each swap (Closed)

Created:
6 years, 1 month ago by bajones
Modified:
6 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, kalyank, ozone-reviews_chromium.org, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Allow Windows to use system Vsync for a single window each swap This makes the common case (one browser window) smoother, but doesn't help multi-window smoothness much. BUG=422000 Committed: https://crrev.com/3f72599ead7c0ee7922afedf93ffae17f5f45f88 Cr-Commit-Position: refs/heads/master@{#303074}

Patch Set 1 #

Total comments: 3

Patch Set 2 : Comment spelling correction #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -13 lines) Patch
M content/common/gpu/image_transport_surface.cc View 2 chunks +0 lines, -12 lines 0 comments Download
M ui/gl/gl_context_egl.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.h View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/gl/gl_surface.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.h View 2 chunks +6 lines, -0 lines 0 comments Download
M ui/gl/gl_surface_egl.cc View 1 4 chunks +34 lines, -1 line 0 comments Download

Messages

Total messages: 14 (3 generated)
bajones
I'm pretty conflicted about this "fix", but ultimately I do believe that it will provide ...
6 years, 1 month ago (2014-11-05 20:05:16 UTC) #2
brianderson
https://codereview.chromium.org/708483003/diff/1/ui/gl/gl_surface.cc File ui/gl/gl_surface.cc (right): https://codereview.chromium.org/708483003/diff/1/ui/gl/gl_surface.cc#newcode268 ui/gl/gl_surface.cc:268: void GLSurface::SetSwapInterval(int interval) { Is this empty implementation okay?
6 years, 1 month ago (2014-11-06 00:04:58 UTC) #3
bajones
https://codereview.chromium.org/708483003/diff/1/ui/gl/gl_surface.cc File ui/gl/gl_surface.cc (right): https://codereview.chromium.org/708483003/diff/1/ui/gl/gl_surface.cc#newcode268 ui/gl/gl_surface.cc:268: void GLSurface::SetSwapInterval(int interval) { On 2014/11/06 00:04:58, brianderson wrote: ...
6 years, 1 month ago (2014-11-06 00:09:56 UTC) #4
jbauman
lgtm
6 years, 1 month ago (2014-11-06 00:22:30 UTC) #5
brianderson
lgtm
6 years, 1 month ago (2014-11-06 00:36:40 UTC) #6
bajones
Thanks for the reviews! kbr@, could you provide and owners review for ui/gl?
6 years, 1 month ago (2014-11-06 00:40:03 UTC) #8
Ken Russell (switch to Gerrit)
lgtm https://codereview.chromium.org/708483003/diff/1/ui/gl/gl_surface_egl.cc File ui/gl/gl_surface_egl.cc (right): https://codereview.chromium.org/708483003/diff/1/ui/gl/gl_surface_egl.cc#newcode464 ui/gl/gl_surface_egl.cc:464: // each surface present on it's own thread. ...
6 years, 1 month ago (2014-11-06 06:25:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708483003/20001
6 years, 1 month ago (2014-11-06 18:48:39 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-06 19:47:34 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/3f72599ead7c0ee7922afedf93ffae17f5f45f88 Cr-Commit-Position: refs/heads/master@{#303074}
6 years, 1 month ago (2014-11-06 19:49:02 UTC) #13
bajones
6 years, 1 month ago (2014-11-12 00:30:07 UTC) #14
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/710393003/ by bajones@chromium.org.

The reason for reverting is: Possibly introduced regressions into
smoothness.tough_scrolling_cases

https://code.google.com/p/chromium/issues/detail?id=431599.

Powered by Google App Engine
This is Rietveld 408576698