Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Issue 708483002: Revert of Reland "Switch telemetry over to use typ to run the unit tests." (Closed)

Created:
6 years, 1 month ago by Paweł Hajdan Jr.
Modified:
6 years, 1 month ago
Reviewers:
dtu, Dirk Pranke, tonyg, nduca
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland "Switch telemetry over to use typ to run the unit tests." (patchset #1 id:1 of https://codereview.chromium.org/707453002/) Reason for revert: This seems to return with 0 exit code when tests are failing, see e.g. http://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/18/steps/telemetry_perf_unittests/logs/stdio . Previous build was correctly reporting the steps as failed (http://build.chromium.org/p/chromium.mac/buildstatus?builder=Mac10.9%20Tests%20%28dbg%29&number=17). Original issue's description: > Reland "Switch telemetry over to use typ to run the unit tests." > > Original review: https://codereview.chromium.org/659293003 > > Using typ allows us to run the tests in parallel and share > the logic for parsing the results and uploading them to the > flakiness dashboard with other python test steps. > > TBR=dtu@chromium.org, tonyg@chromium.org, nduca@chromium.org, dpranke@chromium.org > BUG=402172, 388256 > > Committed: https://chromium.googlesource.com/chromium/src/+/fc4a811ffe26653019e2213947146a721620e0fc TBR=dpranke@chromium.org,dtu@chromium.org,nduca@chromium.org,tonyg@chromium.org NOTREECHECKS=true NOTRY=true BUG=402172, 388256 Committed: https://chromium.googlesource.com/chromium/src/+/b0d9981737dbe92852366bf416f19dfcb978d6c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+524 lines, -316 lines) Patch
M tools/perf/run_tests View 1 chunk +10 lines, -15 lines 0 comments Download
M tools/telemetry/PRESUBMIT.py View 1 chunk +1 line, -3 lines 0 comments Download
M tools/telemetry/bootstrap_deps View 1 chunk +30 lines, -17 lines 0 comments Download
M tools/telemetry/run_tests View 1 chunk +8 lines, -14 lines 0 comments Download
M tools/telemetry/telemetry/decorators.py View 3 chunks +16 lines, -64 lines 0 comments Download
M tools/telemetry/telemetry/unittest/browser_test_case.py View 1 chunk +14 lines, -35 lines 0 comments Download
A tools/telemetry/telemetry/unittest/json_results.py View 1 chunk +247 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_chromeos_tests.py View 2 chunks +26 lines, -18 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests.py View 3 chunks +154 lines, -125 lines 0 comments Download
M tools/telemetry/telemetry/unittest/run_tests_unittest.py View 2 chunks +17 lines, -17 lines 0 comments Download
M tools/telemetry/telemetry/web_perf/timeline_based_measurement_unittest.py View 4 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paweł Hajdan Jr.
Created Revert of Reland "Switch telemetry over to use typ to run the unit tests."
6 years, 1 month ago (2014-11-05 15:25:24 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b0d9981737dbe92852366bf416f19dfcb978d6c6 Cr-Commit-Position: refs/heads/master@{#302804}
6 years, 1 month ago (2014-11-05 15:37:18 UTC) #3
Paweł Hajdan Jr.
6 years, 1 month ago (2014-11-05 15:37:20 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b0d9981737dbe92852366bf416f19dfcb978d6c6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698