Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 708383003: Move 4 UI components to FileManagerUI class from FileManager. (Closed)

Created:
6 years, 1 month ago by hirono
Modified:
6 years, 1 month ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move 4 UI components to FileManagerUI class from FileManager. * ProgressCenterPanel * DirectoryTree * GearButton * TaskItems (ComboButton) BUG=267281 TEST=None Committed: https://crrev.com/9291040409959e3c1f3e9e333660d25c40fdd968 Cr-Commit-Position: refs/heads/master@{#303626}

Patch Set 1 #

Patch Set 2 : Rebased. #

Patch Set 3 : Add comments. #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -148 lines) Patch
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 2 3 20 chunks +45 lines, -141 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_selection.js View 2 chunks +3 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/file_manager_ui.js View 1 2 3 7 chunks +112 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
hirono
PTAL the CL? Thank you!
6 years, 1 month ago (2014-11-10 11:02:28 UTC) #2
fukino
On 2014/11/10 11:02:28, hirono wrote: > PTAL the CL? Thank you! lgtm!
6 years, 1 month ago (2014-11-11 04:55:47 UTC) #3
hirono
On 2014/11/11 04:55:47, fukino wrote: > On 2014/11/10 11:02:28, hirono wrote: > > PTAL the ...
6 years, 1 month ago (2014-11-11 09:41:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708383003/40001
6 years, 1 month ago (2014-11-11 09:41:47 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/23420) linux_chromium_asan_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/9661) linux_chromium_compile_dbg_32 ...
6 years, 1 month ago (2014-11-11 09:45:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/708383003/60001
6 years, 1 month ago (2014-11-11 11:10:42 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-11-11 12:21:10 UTC) #12
commit-bot: I haz the power
6 years, 1 month ago (2014-11-11 12:21:56 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/9291040409959e3c1f3e9e333660d25c40fdd968
Cr-Commit-Position: refs/heads/master@{#303626}

Powered by Google App Engine
This is Rietveld 408576698