Issue 708323002: Suspect that this is causing crash, reverting.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 708323002: Suspect that this is causing crash, reverting. (Closed)

Created:
6 years, 1 month ago by matthewyuan

Modified:
6 years, 1 month ago

Reviewers:

CC:
chromium-reviews, peter+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2214

Project:
chromium

Visibility:
Public.

More Reviews

Description

Suspect that this is causing crash, reverting. Revert "Disable notification views when clearing all notifications" This reverts commit e38e7b4b295e521e6bdbbacf50ab07fdea842d25. BUG= Committed: https://chromium.googlesource.com/chromium/src/+/777ddc48181a23562af94c13e57fadebac33e75e

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -12 lines)			Patch
	M	ui/message_center/views/message_center_view.cc	View		3 chunks	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

matthewyuan

Committed patchset #1 (id:1) manually as 777ddc48181a23562af94c13e57fadebac33e75e.

6 years, 1 month ago (2014-11-08 23:48:25 UTC) #1

myuan

6 years, 1 month ago (2014-11-10 17:32:21 UTC) #2

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/711073002/ by matthewyuan@google.com.

The reason for reverting is: Suspect cl is innocent..

Expand Messages | Collapse Messages