Issue 708253002: win: update the toolchain if necessary

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 708253002: win: update the toolchain if necessary (Closed)

Created:
6 years, 1 month ago by scottmg

Modified:
6 years, 1 month ago

Reviewers:
jam

CC:
mojo-reviews_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

win: update the toolchain if necessary R=jam@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/d7f3bd8ab2476f150ca58fad7745853466f6e9f2

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	DEPS	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

this will do it earlier and then the gn update won't start a whole bunch ...

6 years, 1 month ago (2014-11-08 04:11:14 UTC) #1

scottmg

Committed patchset #1 (id:1) manually as d7f3bd8ab2476f150ca58fad7745853466f6e9f2.

6 years, 1 month ago (2014-11-08 04:15:41 UTC) #2

jam

6 years, 1 month ago (2014-11-08 04:16:26 UTC) #3

Message was sent while issue was closed.

On 2014/11/08 04:11:14, scottmg wrote:
> this will do it earlier and then the gn update won't start a whole bunch of
them
> in threaded mode (it'll just early out). this is what chrome does too

lgtm, thanks!

Expand Messages | Collapse Messages