sky/engine/core/editing/markup.cpp - Issue 708233002: Remove many attributes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/core/editing/markup.cpp

Issue 708233002: Remove many attributes. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sky/engine/core/editing/markup.cpp

diff --git a/sky/engine/core/editing/markup.cpp b/sky/engine/core/editing/markup.cpp

index 478c13ed3d5e9954a9a86b7f7d800a2dbcb5cc0a..7bd63562a37a09ccb34e471b8b90e1c9194489eb 100644

--- a/sky/engine/core/editing/markup.cpp

+++ b/sky/engine/core/editing/markup.cpp

@@ -476,12 +476,6 @@ static String createMarkupInternal(Document& document, const Range* range, const

if (ancestor == fullySelectedRoot && !convertBlocksToInlines) {

RefPtr<EditingStyle> fullySelectedRootStyle = styleFromMatchedRulesAndInlineDecl(fullySelectedRoot);

- // Bring the background attribute over, but not as an attribute because a background attribute on a div

- // appears to have no effect.

- if ((!fullySelectedRootStyle || !fullySelectedRootStyle->style() || !fullySelectedRootStyle->style()->getPropertyCSSValue(CSSPropertyBackgroundImage))

- && fullySelectedRoot->hasAttribute(HTMLNames::backgroundAttr))

- fullySelectedRootStyle->style()->setProperty(CSSPropertyBackgroundImage, "url('" + fullySelectedRoot->getAttribute(HTMLNames::backgroundAttr) + "')");

if (fullySelectedRootStyle->style()) {

// Reset the CSS properties to avoid an assertion error in addStyleMarkup().

// This assertion is caused at least when we select all text of a <body> element whose

« no previous file with comments | « sky/engine/core/dom/Document.cpp ('k') | sky/engine/core/html/HTMLAttributeNames.in » ('j') | no next file with comments »