Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(426)

Issue 708163002: Add iframe.sky test expectations for dump-as-render-tree. (Closed)

Created:
6 years, 1 month ago by Matt Perry
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, abarth-chromium, mojo-reviews_chromium.org, ojan
Base URL:
https://github.com/domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -1 line) Patch
M sky/tests/lowlevel/iframe.sky View 1 chunk +4 lines, -1 line 0 comments Download
A sky/tests/lowlevel/iframe-expected.txt View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Matt Perry
test_sky works for me now.
6 years, 1 month ago (2014-11-07 22:07:17 UTC) #2
esprehn
lgtm
6 years, 1 month ago (2014-11-07 22:13:02 UTC) #3
Matt Perry
6 years, 1 month ago (2014-11-07 22:14:26 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e50876a5ed929f94a3f0979ffb3f25fcfab56a4a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698