Issue 708133002: win: build fixes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 708133002: win: build fixes (Closed)

Created:
6 years, 1 month ago by scottmg

Modified:
6 years, 1 month ago

Reviewers:
jam

CC:
mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Project:
mojo

Visibility:
Public.

More Reviews

Description

win: build fixes With https://codereview.chromium.org/709793002/ for base/, build/, gpu/, 'mojo' builds in mojo again. R=jam@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9ec4eb1de8cf10b13c5b3711df19c1dea0652a5b

Patch Set 1 #

Patch Set 2 : . #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -7 lines)			Patch
M	crypto/BUILD.gn	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	mojo/shell/dynamic_application_loader.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/BUILD.gn	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	services/http_server/BUILD.gn	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	third_party/libxml/BUILD.gn	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/zlib/BUILD.gn	View		2 chunks	+5 lines, -2 lines	0 comments	Download
M	ui/gfx/platform_font_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/BUILD.gn	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/controls/menu/menu_config_win.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scottmg

6 years, 1 month ago (2014-11-07 23:35:26 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9ec4eb1de8cf10b13c5b3711df19c1dea0652a5b (presubmit successful).

Expand Messages | Collapse Messages