Source/bindings/core/v8/V8ScriptRunner.cpp - Issue 708093002: Script streaming: remove byte order marks, detect encoding based on them.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 708093002: Script streaming: remove byte order marks, detect encoding based on them. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/core/v8/ScriptStreamer.cpp ('K') | « Source/bindings/core/v8/ScriptStreamerTest.cpp ('k') | Source/core/html/parser/TextResourceDecoder.h » ('j') | Source/core/html/parser/TextResourceDecoder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/V8ScriptRunner.cpp

diff --git a/Source/bindings/core/v8/V8ScriptRunner.cpp b/Source/bindings/core/v8/V8ScriptRunner.cpp

index 32c1659c872e8b86209ad46c5ca06629f3132916..86c068eb7bae68bc2ca4f0a8c0f7b36541016a68 100644

--- a/Source/bindings/core/v8/V8ScriptRunner.cpp

+++ b/Source/bindings/core/v8/V8ScriptRunner.cpp

@@ -129,7 +129,7 @@ v8::Local<v8::Script> V8ScriptRunner::compileScript(v8::Handle<v8::String> code,

resource->clearCachedMetadata();

// Temporarily disable cached metadata for streaming; it's

// producing broken data. FIXME: enable it again.

- // resource->setCachedMetadata(streamer->cachedDataType(), reinterpret_cast<const char*>(newCachedData->data), newCachedData->length);

+ resource->setCachedMetadata(streamer->cachedDataType(), reinterpret_cast<const char*>(newCachedData->data), newCachedData->length);

}

} else if (!resource || !resource->url().protocolIsInHTTPFamily() || code->Length() < 1024) {

v8::ScriptCompiler::Source source(code, origin);